epugh commented on code in PR #4853:
URL: https://github.com/apache/solr/pull/4853#discussion_r4006392225


##########
solr/solr-ref-guide/modules/indexing-guide/pages/indexing-with-tika.adoc:
##########
@@ -384,6 +384,18 @@ Example: `passwordsFile=/path/to/passwords.txt`
 // +
 // Only applicable for `tikaserver` backend. Can only be set in 
`solrconfig.xml`, not per request.
 
+`tikaserver.config`::
++
+[%autowidth,frame=none]
+|===
+|Optional |Default: none
+|===
++
+A raw JSON object sent as the per-request parser configuration for Tika Server 
(e.g., `{"pdf-parser":{"ocr":{"strategy":"NO_OCR"}}}`).
+See <<Parser-Specific Properties>> below for details and an important security 
note: this requires `allowPerRequestConfig=true` on the Tika Server, which is 
off by default.
++
+Example: `tikaserver.config={"pdf-parser":{"ocr":{"strategy":"NO_OCR"}}}`

Review Comment:
   @janhoy I think I am coming around to your perspective.  AT least, for now.  
 We are intentially seperating out the Tika server part.
   
   It would be maybe different if the extraction module "knew" smart things and 
needed to update Tika to do what it needed...    Then it might be cool to 
someohwo do that.   But yeah, right now, not seeing htis.    I am going to rip 
this back out, and instead update the indexing-with-tika.adoc to call out how 
you confirued tika.    
   
   Another great example of **WWJD**!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to