[
https://issues.apache.org/jira/browse/SOLR-17316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18115729#comment-18115729
]
ASF subversion and git services commented on SOLR-17316:
--------------------------------------------------------
Commit 6de34ce6cd60c4d92d937ce8c9f6732a814bfe64 in solr's branch
refs/heads/main from Serhiy Bzhezytskyy
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=6de34ce6cd6 ]
SOLR-17316: New SolrJ CanonicalJsonResponseParser for use with QueryResponse
and others (#4640)
SolrJ's QueryResponse and other response objects can now read a JSON response
via the new CanonicalJsonResponseParser.
Co-authored-by: David Smiley <[email protected]>
> SolrResponseBase getters should work with all ResponseParsers
> --------------------------------------------------------------
>
> Key: SOLR-17316
> URL: https://issues.apache.org/jira/browse/SOLR-17316
> Project: Solr
> Issue Type: Bug
> Components: SolrJ
> Affects Versions: 9.6.1, 10.0
> Reporter: Jason Gerlowski
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> SolrJ's SolrResponseBase has several "getter" methods that give users a
> syntactic sugar for accessing common response properties (such as the
> response header's "status" field). These methods are useful, but make
> certain Java class/type assumptions that only hold for some of Solr's
> ResponseParsers.
> For example, "SolrResponseBase.getResponseHeader" returns a NamedList - which
> is correct when the default "BinaryResponseParser" is used, but will cause a
> ClassCastException when used with other parsers (e.g. JsonMapResponseParser)
> We have a few options for how to remedy this:
> 1. Make these SolrResponseBase methods a little more flexible in the types
> they return and the variety of types they can handle as they walk the
> response NamedList
> 2. Try to align all ResponseParser implementations around using types
> similarly.
> 3. If (1) and (2) are infeasible, we could at least add Javadocs to these
> SolrResponseBase methods to indicate that they may throw CCE, and that
> they're only guaranteed to work with the BinaryResponseParser.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
