dsmiley commented on code in PR #4676: URL: https://github.com/apache/solr/pull/4676#discussion_r4139856754
########## changelog/unreleased/SOLR-18324-jersey-null-request-npe.yml: ########## @@ -0,0 +1,7 @@ +title: Fixed a race condition where V2 (JAX-RS) API requests that fail before a SolrQueryRequest is attached to the request context could throw a NullPointerException while building the error response, which could cascade into an internal request-metrics-timer assertion failure under Solr's security manager / assertions-enabled test builds. Review Comment: minor nit: this is a long explanation for an NPE in a changelog -- great explanation for a PR description, say. I suggest simply: > The V2 JAX-RS API, when faced with an error, could throw an NPE masking the true problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
