nick-boss-tech commented on PR #4829: URL: https://github.com/apache/solr/pull/4829#issuecomment-5920255221
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* I found one Cloud direct-update case that needs a guard before this lands. `RouteException` is created after collecting shard outcomes, so a `RequestNotSentException` from one route does not prove another shard did not already apply the update. Using `wasRequestUnsent(exc)` to authorize a whole `UPDATE` replay can double-apply an atomic `inc`. The unsent predicate is appropriate for per-endpoint LB failover, but Cloud should not promote a shard-local marker into a whole-request retry. Could we keep whole `UPDATE` replay disabled for this path, unless it is separately proven idempotent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
