nick-boss-tech commented on PR #4965: URL: https://github.com/apache/solr/pull/4965#issuecomment-6000482513
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* It does not relate, and I can show that rather than just assert it. I ran `DirectUpdateHandlerTest` locally with the run's exact seed (71E7F210A62A9B8C) on two trees: * On pristine `main` (e432df19c4a, no part of this change), the same three failures reproduce: `testExpungeDeletes` with the same `maxDoc !> numDocs` assertion at DirectUpdateHandlerTest.java:494, `testDeleteRollback` in teardown, and the ObjectTracker fallout. * On this PR's head (9448cda146f), all 7 methods pass under the same seed. I would not read the head passing as the change fixing anything there; the two methods depend on timing-sensitive deletion visibility that a seed does not fully pin, so they can flip either way. The point is only that unmodified main produces the identical failure set with the identical seed and assertion text, so the failure pre-exists this PR. Structurally, the change touches nothing in the update path: the two production files are `DocsStreamer` and `EmbeddedSolrServer` (stored field value conversion for the embedded streaming response path), plus the changelog and two test files. `DirectUpdateHandler` and the commit/expunge/rollback logic are untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
