janhoy commented on code in PR #5059:
URL: https://github.com/apache/solr/pull/5059#discussion_r4218130309
##########
solr/core/src/test/org/apache/solr/cloud/TestGracefulJettyShutdown.java:
##########
@@ -41,11 +41,9 @@
import org.apache.solr.handler.component.SearchHandler;
import org.apache.solr.request.SolrQueryRequest;
import org.apache.solr.response.SolrQueryResponse;
-import org.junit.Ignore;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-@Ignore("Flaky from Jetty 12.1.10 upgrade
https://issues.apache.org/jira/browse/SOLR-18297";)
public class TestGracefulJettyShutdown extends SolrTestCaseJ4 {
Review Comment:
I'd say we make this test `@Nightly` since its main purpose was to validate
the jetty fix.
And this test should probably extend `SolrTestCase`, not the J4 one...
That's a minor..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
