[
https://issues.apache.org/jira/browse/SOLR-18119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18128043#comment-18128043
]
Nick Shanin commented on SOLR-18119:
------------------------------------
The next step could be PR #5061: [https://github.com/apache/solr/pull/5061]. It
is the converter half on its own: \{{ChangesToHtml}} ported to Java,
\{{changes2html.py}} removed, and nothing else from the original problem
statement left in it now that SOLR-18523 has landed. It adds 1200 lines and
removes 900 lines. The one thing the pair leaves behind is fragment anchor
checking, which the removed crawl did provide; that stays named as a follow-up
in #5061 rather than folded into it.
AI-generated, human-reviewed text.
> Changes.html generation is quietly skipped if python3 not found, can cause
> downstream tasks to fail confusingly
> ----------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-18119
> URL: https://issues.apache.org/jira/browse/SOLR-18119
> Project: Solr
> Issue Type: Bug
> Reporter: Chris M. Hostetter
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> ChangesToHtmlTask will log a warning if python3 doesn't exist – but it does
> not fail.
> downstream tasks that (implicitly) depend on the existence of Changes.html
> will subsequently fail...
>
> {noformat}
> :solr:documentation:checkBrokenLinks
> :solr:solr-ref-guide:checkSiteLinks{noformat}
>
> This can be very confusing on jenkins boxes – such as our Windows jenkins
> build, which does not have python3 – when people don't know/realize that
> {{:solr:documentation:changesToHtml}} quietly did nothing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
