syahra712 commented on issue #5: URL: https://github.com/apache/solr-orbit/issues/5#issuecomment-6233891427
Hi @janhoy, I started looking at this. While tracing how telemetry is wired, I found a few places where the code doesn't do what the docs say: - `cluster-environment-info` appears in `solr-orbit list telemetry` and in the docs, but nothing creates `ClusterEnvironmentInfo`. As a result, `--telemetry cluster-environment-info` does nothing. - The `run` pipelines (docker, from-distribution, from-sources) never pass `telemetry_devices` to `SolrProvisioner` / `SolrDockerLauncher`. That means jfr/gc/jit/heapdump/disk-io never turn on under `run`. Only the older `builder/launcher.py` path used by `start`/`stop` wires them up. - `--telemetry-params collection-stats-sample-interval` is documented, but nothing reads it. `SolrCollectionStats` always uses the 30 s default. A developer guide written today would have to describe this as it is. Would you prefer these fixed first, so the guide can describe one working path? If so, I'm happy to open an issue and small PRs for them, starting with `cluster-environment-info`. Or would you rather have the guide first, with these noted as known gaps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
