nick-boss-tech commented on PR #5060:
URL: https://github.com/apache/solr/pull/5060#issuecomment-6260845993
Hi @dsmiley, I took a look at this.
branch_9x backport of SOLR-18522 (PR #5060): two changes are needed for
CombinedQueryComponentTest to compile and pass on branch_9x.
1. Compile: the JSON text block is a Java 15 feature and branch_9x builds
with --release 11. Rewriting the literal as string concatenation fixes the
compile.
2. testFacetWithSmallMatchesAcrossSegments: branch_9x's
BaseDistributedSearchTestCase has no query(String handler, SolrParams)
overload, unlike branch_10x. The call query("/search", params(...)) therefore
resolves to query(Object...), which turns "/search" into a parameter with no
query and no JSON body. Both sides return 0 documents, and the distributed side
then reports maxScore 0.0 against a null control, so the test fails. Passing
the handler as a parameter, params(CommonParams.QT, "/search", ...), fixes it.
Verified locally on branch_9x with JDK 11, release 11, seed
18522C0FFEE18522: CombinedQueryComponentTest 7/7 pass with both changes.
My branch for this:
https://github.com/nick-boss-tech/solr/tree/solr-18522-9x-backport-fix
AI investigated this and wrote the comment and I reviewed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
