janhoy commented on PR #5110: URL: https://github.com/apache/solr/pull/5110#issuecomment-6289857149
@dsmiley Do you feel strongly about this vs your approach in #5112 ? David's more generic solution would proxy individual requests rather than aggregate, and would require the Admin UI to send N individual requests to the `localhost:8983/solr/admin/foo` endpoint with a header `X-Solr-targetNode: otherNode3:8983_solr`. What I like the most about the ServletFilter approach is that the response shape stays the same and is thus more true to REST / OpenAPI. I.e. AdminUI can use a generated V2 API class to talk to logging / threads / xxx endpoint and get the response as an object. Less special code in UI, and less special code in Solr. What I like with the current PR is that it is ready, mergable and re-uses the same mechanism already used in AdminUI. It could ship in 10.2 and a refactor to `X-Solr-targetNode` could ship in a later version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
