[
https://issues.apache.org/jira/browse/SOLR-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130161#comment-18130161
]
Nick Shanin commented on SOLR-18565:
------------------------------------
A one-line fix for the assertion is on a branch:
[https://github.com/nick-boss-tech/solr/tree/solr-18565-submit]. The diff
against upstream main is here:
[https://github.com/apache/solr/compare/main...nick-boss-tech:solr:solr-18565-submit].
It changes {{solr/packaging/test/test_ssl.bats}} line 103 to match the shared
prefix "no alternative certificate subject name matches target host", so the
test passes with both "target host name" and "target hostname". The bats job
has not been run on the branch yet.
_AI-generated comment._
> test_ssl.bats "use different hostname when not checking peer-name" fails on
> the ubuntu-26.04 runner: curl changed its hostname-mismatch wording
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-18565
> URL: https://issues.apache.org/jira/browse/SOLR-18565
> Project: Solr
> Issue Type: Test
> Reporter: Nick Shanin
> Priority: Minor
>
> * *Summary*
> test_ssl.bats "use different hostname when not checking peer-name" fails on
> the ubuntu-26.04 runner image with a different curl error message
> *Description*
> Test 88, "use different hostname when not checking peer-name", fails at
> solr/packaging/test/test_ssl.bats line 103. It is the only failing test in
> the bats job log for
> [https://github.com/apache/solr/actions/runs/39688109570/job/119558270184], a
> run of pull request [https://github.com/apache/solr/pull/5190]. That PR does
> not change SSL code.
> The assertion expects curl's output to contain "no alternative certificate
> subject name matches target host name". In this run curl exited with code 60
> and printed:
> {{curl: (60) SSL: no alternative certificate subject name matches target
> hostname 'localhost'}}
> The only difference is "hostname" where the test expects "host name". Earlier
> steps in the same test pass in this run, including starting Solr with SSL and
> running solr create and solr api over https.
> The same test passed on the ubuntu-24.04 runner image in two recent runs of
> the same workflow: [https://github.com/apache/solr/actions/runs/38613980754]
> (2026-10-14) and [https://github.com/apache/solr/actions/runs/39499583835]
> (2026-10-21). Both show "ok 88 use different hostname when not checking
> peer-name". Those runs are on the SOLR-18234 branch, not the PR's branch, and
> their logs do not print curl's message, so the wording on that image is
> inferred from the passing assertion.
> *Suggested fix:* match the stable part of the message, for example "no
> alternative certificate subject name matches target host", or check for
> curl's exit code 60.
> *Reproduction:* run the Solr Script Tests job on the ubuntu-26.04 runner
> image (20261012.163) with test_ssl.bats as it is at
> 78923482727b8530d26ad08db734712ab2dacb12. The expected failure is at line 103
> with the message above.
> AI-generated, human-approved text.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
