nick-boss-tech opened a new pull request, #5193: URL: https://github.com/apache/solr/pull/5193
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* https://issues.apache.org/jira/browse/SOLR-18565 ## What happens today **Test 88 fails on the ubuntu-26.04 runner image because curl's error text changed.** Test 88 ("use different hostname when not checking peer-name") is at [test_ssl.bats line 103](https://github.com/nick-boss-tech/solr/blob/7892348272/solr/packaging/test/test_ssl.bats#L103) on the base commit. It expects curl's output to contain "no alternative certificate subject name matches target host name". On ubuntu-26.04, curl exits with code 60 and prints "...matches target hostname 'localhost'". The word "hostname" does not match "host name", so the assertion fails. This is the only failing test in the job log of [this run of PR #5190](https://github.com/apache/solr/actions/runs/39688109570/job/119558270184). Test 88 passed on ubuntu-24.04 in [run 38613980754](https://github.com/apache/solr/actions/runs/38613980754) and [run 39499583835](https://github.com/apache/solr/actions/runs/39499583835). Those runs are on the SOLR-18234 branch. ## What this change does **The assertion matches only the part of the message that both wordings share.** The expected text on [line 103](https://github.com/nick-boss-tech/solr/blob/2c747689c32bd17a6327ecd2b60999b972771269/solr/packaging/test/test_ssl.bats#L103) is shortened to "no alternative certificate subject name matches target host". The rest of the test is unchanged, and the check still asserts that verification fails. No product code changes. ## Proof **This is a test-only change, so the proof is inconclusive by construction.** A failing-then-passing unit test does not apply here. Checks made: - The new expected text is a substring of the curl message in the failing run. Checked by string match. - The new text is also a prefix of the ubuntu-24.04 wording, so test 88 should still pass there. Not run. The bats job has not been run on this branch. It needs the packaging build, which CI runs. ## Limits - The bats job has not run on this branch. - Only one failing run was read. Other PRs on the ubuntu-26.04 image were not checked. - No other bats file uses the old wording (checked with a grep of `solr/packaging` at the base commit). Changelog: none. This is a test-only change and is not user-facing. *AI-generated description. Nick Shanin directed the work and takes responsibility for this contribution.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
