nick-boss-tech commented on PR #5140: URL: https://github.com/apache/solr/pull/5140#issuecomment-6355270230
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* @dsmiley, this is the follow-up to [#5188](https://github.com/apache/solr/pull/5188). Please review the raw-glob change in `SolrReturnFields` and the writer check first. **Recommendation:** review the raw-glob path first. It is the part that changes behavior. - Merge order: #5188 first. This PR then applies with one conflict, in `TestExportWriter.java`, where both PRs add tests at the end of the file. The production code has no conflicts in either order. - This PR does not include your `ReturnFields` methods. Three tests in `ReturnFieldsTest` use `wantsLuceneField` and `isExplicitLuceneField`, so they are left out here. They come in after #5188 merges. - The base fails 15 of 17 `TestRawTransformer` cases and 2 of 22 `TestExportWriter` cases. Main plus this change passes them all ([body](https://github.com/apache/solr/pull/5140)). - One choice needs your view: a renamed field under a raw glob comes back plain. The body explains the two options and the recommendation. Bottom line: if the raw-glob design looks right, the rest is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
