nick-boss-tech commented on PR #5205: URL: https://github.com/apache/solr/pull/5205#issuecomment-6368738213
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* The change is safe on both Caffeine versions, so it can merge once the title and body are fixed. On fe797ea, TestCaffeineCache (6/6) and TestThinCache (2/2) pass with Caffeine 3.2.4 on main. The same 8 tests pass with 3.3.0, the version branch_9x uses since [#4976](https://github.com/apache/solr/pull/4976). That bump is the cause: Caffeine 3.3.0 evicts a different entry for this sequence, so the tests should not assert which key is gone. The [compare view](https://github.com/apache/solr/compare/main...iamsanjay:solr:cache-tests-eviction-order) shows the test-only change. Caffeine by branch: main (11.0) and branch_10x (10.2) use 3.2.4. branch_10_0 (10.0.x) uses 3.2.2. branch_9_11 (9.11.x) uses 3.2.4. branch_9x (9.12 dev) uses 3.3.0. Only branch_9x is affected. The email that prompted this cites [#4967](https://github.com/apache/solr/pull/4967). That PR is SOLR-18134. The bump is #4976. **Recommendation:** Merge this to main, and have David Smiley do the branch_9x backport, since the diff does not apply there as-is (the test files differ). Before merge: 1. Title: start with the JIRA key, as the [contribution guide](https://github.com/apache/solr/blob/main/dev-docs/how-to-contribute.adoc) requires (`SOLR-12345: New feature`). Also fix the "Caffein" typo. 2. Body: replace the email text with the root cause and the branch table above. 3. Order: the unmerged SOLR-18506 branch changes the same `backing.setMaxSize(200)` line in TestThinCache. Settle the merge order before either lands. Once the title and body are fixed, this can merge to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
