janhoy commented on code in PR #855: URL: https://github.com/apache/solr-operator/pull/855#discussion_r4367064354
########## .github/workflows/dependabot-licenses.yaml: ########## @@ -0,0 +1,109 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Dependabot cannot run "make fetch-licenses-list", so every Go dependency bump +# it opens fails "make check-licenses" until a human regenerates +# dependency_licenses.csv. This workflow does that step for Dependabot PRs: Review Comment: This turns out not to be true. We had only one open dependabot issue at the time #845 and it failed license check. But all the new dep upgrade PRs dependabot has opened last few days do pass the tests, so this might now be necessary. Would be cool if we could say `@fix-licenses` in a comment and this workflow would run on demand... Right now I vote for skipping this part and do it manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
