dsmiley commented on code in PR #5188:
URL: https://github.com/apache/solr/pull/5188#discussion_r4367929910
##########
solr/core/src/java/org/apache/solr/search/ReturnFields.java:
##########
@@ -104,6 +104,20 @@ public Set<String> getNonScoreDependentReturnFieldNames() {
*/
public abstract boolean wantsField(String name);
+ /**
+ * Returns <code>true</code> if the value of the specified index field is
needed, either to return
+ * or for use by transformers. This is <code>false</code> for a field that
only shares its name
+ * with a pseudo field (e.g. an alias or a transformer), unless
<code>*</code> was requested.
+ */
+ public abstract boolean wantsLuceneField(String field);
Review Comment:
I proposes use of the word "loads". So `loadsLuceneField` or perhaps just
`loadsField` as I'd be happy to drop the word "Lucene" as well.
`wantsField` ought to be renamed to `returnsField` with an important note in
the javadocs that the name returned might be a synthetic label sourced by
anything (same field, another field, a transformer output computed from
anything). We can do this leaving the current name deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
