nick-boss-tech commented on PR #5191: URL: https://github.com/apache/solr/pull/5191#issuecomment-6389502239
**Quick Review:** The fix correctly rebuilds each retry from the supplied aliases state, changes only router.start, and avoids writing when the alias has disappeared. **Optional coverage improvements:** - Preserve a concurrent change to another property on the same alias. - Verify deletion before the asynchronous update does not recreate the alias. The existing regression test meaningfully exercises the stale-cache scenario. AI-generated. Static review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
