nick-boss-tech commented on PR #5119: URL: https://github.com/apache/solr/pull/5119#issuecomment-6392297688
**AI Review: Two follow-ups:** - P3: The [explain test](https://github.com/apache/solr/blob/f6af74c305c07f06eea628e64f0f9b84e38dcb39/solr/core/src/test/org/apache/solr/handler/component/combine/ReciprocalRankFusionTest.java#L173-L187) doesn’t force map order to differ from request order, so it misses the original rank-labeling failure. Use a deliberately reversed LinkedHashMap fixture. - Description: The body still permits zero weights and claims an upgrade-note addition. The reviewed code rejects zero following reviewer feedback, and that upgrade entry was removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
