nick-boss-tech commented on PR #5238: URL: https://github.com/apache/solr/pull/5238#issuecomment-6511901747
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* Amrit, I exercised the preparation/recording split you described with a [test-only example](https://github.com/nick-boss-tech/solr/compare/aa03c9544968f1d9de9b6b36e2823bcbe76268b9...c2c387064a83def34cece4163eccded28318caeb). A component prepares the query identity and response metadata; a listener copies query/result data for a recording destination. The only added file is `SearchRequestListenerUbiTest.java`; the production hook is unchanged. The nine integration tests cover local and distributed result IDs matching the response, generated and supplied query IDs, one coordinator recording, disabled and unconfigured handlers, destination exceptions, failed/partial searches, and a copied payload used after the embedded request closes. The result tests use ordinary searches with `fl=id`. At `c2c387064a83def34cece4163eccded28318caeb`, all nine tests passed on Linux under both seeds `5238AB1` and `5238AB2`. All 19 existing listener tests and 18 neighboring tests also passed, with no failures, errors or skips. Tidy was clean, and root `check -x test` passed with `NODE_ENV` unset. On Eric's storage concern: the callback still runs synchronously on the request thread, so a slow destination can delay a query. These tests establish exception isolation and the copied-payload contract. PR 2452 integration, persistent sinks, core reload/unload, asynchronous lifetime, redaction and production overhead remain follow-up work. If useful, you can take the tested example as a fast-forward from your current head: ```sh git switch solr-11994-hook git fetch https://github.com/nick-boss-tech/solr.git solr-11994-pr5238-ubi-submit git merge --ff-only c2c387064a83def34cece4163eccded28318caeb ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
