epugh commented on code in PR #5280:
URL: https://github.com/apache/solr/pull/5280#discussion_r4436325448
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -872,6 +872,11 @@ void runCloudExample(CloudExampleParams params) throws
Exception {
Locale.ROOT, "Please enter the port for node%d [%d]: ", (n +
1), cloudPorts[n]);
int port = promptForPort(readInput, n + 1, promptMsg, cloudPorts[n]);
while (!isPortAvailable(port)) {
+ if (usingScriptInputs) {
Review Comment:
That's gnarly bug. Though the fix is good, both for making CI easier but
also locally. I've been bit by running a script not realizing I had a zombied
solr on port 8984 or was already running it in docker on 8983... and then
getting my scripted run blows up obsucrely...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
