epugh commented on code in PR #5107:
URL: https://github.com/apache/solr/pull/5107#discussion_r4444562867
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -139,13 +140,19 @@ public static void exit(int exitStatus) {
/** Runs a tool. */
public static void main(String[] args) throws Exception {
- if (EnvUtils.getPropertyAsBool("solr.picocli", false)) {
+ exit(execute(args));
+ }
+
+ @VisibleForTesting
+ static int execute(String[] args) throws Exception {
+ if (EnvUtils.getPropertyAsBool("solr.picocli", false)
+ || (args.length > 0 && "ssl".equals(args[0]))) {
SSLConfigurationsFactory.current().init();
picocli.CommandLine commandLine = new picocli.CommandLine(new SolrCLI());
propagateCommandSettings(commandLine);
- exit(commandLine.execute(stripEmptyLeadingArg(args)));
+ return commandLine.execute(stripEmptyLeadingArg(args));
Review Comment:
interesting, hope this doesn't break something else!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
