adityamparikh opened a new pull request, #285:
URL: https://github.com/apache/solr-mcp/pull/285

   ## What
   
   Adds `EmbeddedZkSolrContainer`, a `SolrContainer` that starts embedded 
ZooKeeper with `-DzkRun=true`, and uses it at every place the tests create a 
Solr container.
   
   ## Why
   
   Testcontainers launches Solr with a bare `-DzkRun`. Solr 10.1 deprecated 
that property in favour of `solr.zookeeper.server.enabled` and parses its value 
as a boolean, so the empty value aborts startup:
   
   ```
   EnvUtils  Deprecated system property zkRun has been replaced by 
solr.zookeeper.server.enabled
   CoreContainerProvider  Could not start Solr ...
   SolrException: invalid boolean value:
   ```
   
   The container never becomes ready, so every Testcontainers-backed test fails 
(`SolrClientUtilsException: Http Call Status: 503`). The floating 
`solr:10-slim` tag now resolves to 10.1.0, so the Solr 10 compatibility job 
breaks without any code change. `solr:10.0.0-slim` is unaffected.
   
   `-DzkRun=true` is accepted by every supported version; verified by starting 
the container and creating a collection on 9.4 and 10.1.
   
   ## Verification
   
   `./gradlew build` passes against `solr:10-slim` (10.1.0) and against the 
default image.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to