[
https://issues.apache.org/jira/browse/SOLR-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137533#comment-18137533
]
Nick Shanin commented on SOLR-16398:
------------------------------------
Following up on the split shard PR, which merged today: the next two endpoints
are open in [PR #5284|https://github.com/apache/solr/pull/5284], migrating
*rebalance leaders* and *migrate docs* to JAX-RS.
The two endpoints are in one PR, at the top of the 1-2 APIs per PR shape. The
file count overstates it a little: a third of the files are tests, and two are
deletions of the annotated classes being replaced. [~epugh], if you would
rather review the endpoints separately, splitting this into two PRs is a small
change; just say which you prefer.
One test on that PR fails, and the cause sits outside its endpoints: the new
coverage found that any migrated v2 endpoint answers a malformed JSON body with
a 500 instead of a 400, including endpoints already on {{main}}. That fix is
split out into [PR #5285|https://github.com/apache/solr/pull/5285] (currently a
draft), which converts body parse and conversion failures into a 400 in the
JSON message-body reader. Once #5285 lands, #5284 rebases over it and the test
passes with no change there.
🤖 _AI text above_ 🤖 _(reviewed by Nick Shanin)_
> Cosmetic improvements and migration to JAX-RS (miscellaneous coll/core APIs)
> ----------------------------------------------------------------------------
>
> Key: SOLR-16398
> URL: https://issues.apache.org/jira/browse/SOLR-16398
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Affects Versions: 10.0
> Reporter: Jason Gerlowski
> Priority: Major
> Labels: newdev, pull-request-available
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> As mentioned on SOLR-15781, the v2 API currently has an experimental
> designation, and the community has expressed an interest in using this period
> to update our v2 endpoints to be more REST-ful and consistent. The current
> plan is to follow the specific changes laid out in [this
> spreadsheet|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing],
> though of course nothing there is set in stone and there are still warts to
> be worked out.
> While we're touching the code for these endpoints, we should also convert
> them to JAX-RS framework definitions. (This was initially tracked as a
> separate effort - see SOLR-16370 - but the edit that were required ended up
> overlapping so significantly with the "cosmetic" improvements here that in
> practice it almost always makes sense to do the two together.)
> This ticket plans to tackle making the changes required for any APIs not
> covered by any other SOLR-15781 subtask.
> Some helpful links related to these changes these changes. Should help get
> any interested newcomers started!
> * For detailed information on Solr's current and desired v2 APIs see the
> spreadsheet
> [here|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing]
> * [Discussion of how APIs work in Solr
> (video)|https://www.youtube.com/watch?v=iIpvfXBjDog]
> * [Step-by-step guide to creating
> APIs|https://issues.apache.org/jira/browse/SOLR-15737?focusedCommentId=17617923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17617923]
> using the JAX-RS v2 API framework
> * [Example PR for a similar change|https://github.com/apache/solr/pull/1679]
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
