dsmiley commented on code in PR #5281: URL: https://github.com/apache/solr/pull/5281#discussion_r4450308968
########## .github/workflows/validate-changelog.yml: ########## Review Comment: reduced in scope ########## .github/workflows/changelog-comment-command.yml: ########## Review Comment: obsolete ########## .github/PULL_REQUEST_TEMPLATE.md: ########## Review Comment: Rather than give users a checklist for these things, we let an LLM make some judgements to help the user (and reviewers!). ########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -40,7 +40,3 @@ Please review the following and check all that apply: - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. -- [ ] I have run `./gradlew check`. Review Comment: dunno why we had a checkbox for this. ########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -40,7 +40,3 @@ Please review the following and check all that apply: - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. Review Comment: Instead of a checkbox for this matter, seems like should be a super early sentence _in the comment_ like "Prefer PRs against `main` branch!". ########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -40,7 +40,3 @@ Please review the following and check all that apply: - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) Review Comment: I wonder if this check could be automated. It wouldn't be an LLM check but nonetheless it may be practical to inculde in this proposed workflow. ########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -40,7 +40,3 @@ Please review the following and check all that apply: - [ ] I have created a Jira issue and added the issue ID to my pull request title. Review Comment: It's tempting to remove this JIRA issue matter and instead push into the LLM judgement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
