epugh commented on PR #5282: URL: https://github.com/apache/solr/pull/5282#issuecomment-6609446250
are there other options? I went back, and this is what Claude said when I first asked about it: So this isn't really "SOLR-16398 introduced a bug and patched it" — it's a pre-existing latent crash in the global nav controller that the author happened to trip over while testing their split-shard changes in the UI, and fixed with a one-line symptom guard rather than a root-cause fix or a separate ticket. The more correct fix would address why currentCollection is unset at all during that window — e.g.: - Don't delete $scope.currentCollection until the new list has loaded and failed to contain a match, instead of unconditionally clearing it upfront, so the dropdown doesn't flash to blank/undefined on every navigation. - Or guard at the ng-change call site in index.html instead of inside showCollection, so other callers of the collection-selector aren't left exposed to the same unset-during-load window. Are there other potential issues that need fixing in the same vein? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
