kotman12 commented on code in PR #5300:
URL: https://github.com/apache/solr/pull/5300#discussion_r4483393660
##########
solr/packaging/test/test_adminconsole_urls.bats:
##########
@@ -51,6 +51,16 @@ teardown() {
assert_output --partial "{"
}
+@test "assert admin console static assets are revalidated and versioned" {
+ run solr start
+
+ run curl -s -I http://localhost:${SOLR_PORT}/solr/libs/solr/index.js
+ assert_output --partial "Cache-Control: no-cache"
+
+ run curl -s http://localhost:${SOLR_PORT}/solr/
+ refute_output --regexp '(src|href)="[^"]+\.(js|css)"'
Review Comment:
No lookahead in bash regex makes strict version of this validation ugly.
Basically we are making sure there is _some_ query string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
