nick-boss-tech commented on PR #5303: URL: https://github.com/apache/solr/pull/5303#issuecomment-6673593528
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* @ispringer I prepared an optional test-only follow-up for your current version. It adds plain-token and fielded-only checks in both `sow` modes, plus independent `wi-fi` and configured `grackle` synonym-preservation tests. It retains your expanded `pf`/`pf2`/`pf3` and stopword-only `bq` MatchAll coverage. Only `TestExtendedDismaxParser.java` changes. Selected suites passed on your head `fd106e0` (157 tests) and the follow-up `07328d6` (160 tests), with no failures, errors or skips, seed `5303C0DE`, Linux/JDK 21. Root tidy, Error Prone compilation and root `check -x test` passed at the follow-up head with `NODE_ENV` unset. Five compiling mutation controls failed at the intended assertions, including false-mode-only regressions. These are selected-suite results, not a full-suite or performance claim. [Verification details](https://github.com/nick-boss-tech/solr/blob/9981127c1ae999d442c5f15bca806aa9896501ef/receipts/PR-5303-phrase-coverage-round-2.md). If useful, the [test-only diff](https://github.com/nick-boss-tech/solr/compare/fd106e02428bf1d619128029c73ea053fb4aedcb...07328d6973c4bb3385ca6d50bfe871f8808c1550) is one commit directly above your current head and can be taken without rewriting history: ```sh git switch SOLR-18625 git fetch https://github.com/nick-boss-tech/solr.git pr-5303-phrase-coverage-round-2 git merge --ff-only 07328d6973c4bb3385ca6d50bfe871f8808c1550 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
