[ 
https://issues.apache.org/jira/browse/SOLR-18630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18140304#comment-18140304
 ] 

Eric Pugh commented on SOLR-18630:
----------------------------------

Yep, this would be a bug..   It's one reason we started naming our variables 
with the time unit in a lot of places..    -DwaitForZk should continue to work, 
but burp out the deprecation warning.   

We have not yet started removing them...    

Are you interested at taking a crack at a PR for this?  Please do tag me on 
your PR.

> Default wait for ZooKeeper at node startup is 30000 seconds instead of 30
> -------------------------------------------------------------------------
>
>                 Key: SOLR-18630
>                 URL: https://issues.apache.org/jira/browse/SOLR-18630
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 10.0, main(11.0), 10.1
>            Reporter: Julian Chandra Sutadi
>            Priority: Major
>
> When a node starts in SolrCloud mode, {{NodeConfig.loadNodeConfig}} first 
> checks that ZooKeeper is reachable and waits up to 
> {{solr.cloud.wait.for.zk.seconds}} for it. The documented default is 30 
> seconds (Solr Properties reference and {{solr.in.sh}}). However, since 
> SOLR-17864 (the env var / property renaming), the default is 30000 seconds 
> (about 8.3 hours):
> {code:java}
> // in NodeConfig.loadNodeConfig
> int startUpZkTimeOut =
>     1000
>         * Integer.getInteger(
>             "solr.cloud.wait.for.zk.seconds", 
> SolrZkClientTimeout.DEFAULT_ZK_CLIENT_TIMEOUT);
> {code}
> The fallback {{SolrZkClientTimeout.DEFAULT_ZK_CLIENT_TIMEOUT}} is already in 
> milliseconds (30000), but it is multiplied by 1000 as if it were seconds.
> Also, while checking the related configuration code, I found that the old 
> system property {{-DwaitForZk}} (listed as the previous name in the Solr 
> Properties reference) is silently ignored, while the old env var 
> {{SOLR_WAIT_FOR_ZK}} still works with a deprecation warning. Is that 
> intended, given these legacy names are removed in 11.0?



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to