syahra712 opened a new pull request, #153:
URL: https://github.com/apache/solr-orbit/pull/153
`kv_to_map` splits each `key:value` pair with `kv.split(":")`, so any value
that contains a colon crashes the command before it starts. It parses
`--workload-params`, `--telemetry-params`, `--plugin-params`,
`--cluster-config-params` and the CSV form of `--client-options`, so a URL, a
password or a time of day all fail the same way:
```
$ solr-orbit run ... --workload-params
"bulk_size:100,source:'http://mirror:8080/docs.json'"
ValueError: too many values to unpack (expected 2)
```
Keys never contain a colon, so the fix splits on the first colon only
(`kv.split(":", 1)`). The rest of the value, quoting included, is handled as
before.
Tested: added `test_kv_to_map_value_contains_colon` (a URL, an unquoted
password and a time); it fails on main and passes with the fix. `ruff check` is
clean and the full unit suite passes (1181 passed, 5 skipped).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
