agazzarini commented on code in PR #5328:
URL: https://github.com/apache/solr/pull/5328#discussion_r4610574518


##########
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java:
##########
@@ -614,6 +621,7 @@ private static SolrDocument fetchSolrDoc(
       SolrIndexSearcher searcher, int docId, ReturnFields returnFields) throws 
IOException {
     final SolrDocumentFetcher docFetcher = searcher.getDocFetcher();
     final SolrDocument solrDoc = docFetcher.solrDoc(docId, (SolrReturnFields) 
returnFields);
+    removeCopyFieldTargets(solrDoc, searcher.getSchema());

Review Comment:
   Hi @dsmiley here's my thoughts: with SOLR-18207 the SolrDocumentFetcher 
instance (docFetcher::solrDoc) retrieves from the index the document,  
including those vector fields that potentially are copy-field targets. During 
the atomic update, what I wanted to do here is to remove any value on the 
copy-field targets otherwise when the copy directive will be executed it will 
add its values (instead of replacing them). 
   
   ...while I'm writing I see the same filter is also on toSolrInputDocument. 
Is that what you mean? I think we can remove this call



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to