janhoy opened a new pull request, #5362:
URL: https://github.com/apache/solr/pull/5362

   https://issues.apache.org/jira/browse/SOLR-18059
   
   Path validation against `allowPaths` required a `CoreContainer` reference. 
This moves it into a small per-node helper, `AllowListPathChecker`, modelled on 
the existing `AllowListUrlChecker`.
   
   - `AllowListPathChecker.create(NodeConfig)` builds the allow-list 
(SOLR_HOME, coreRootDirectory, configSetBaseDirectory, SOLR_DATA_HOME, solr.xml 
`allowPaths`), logic moved out of the `CoreContainer` constructor
   - `CoreContainer.assertPathAllowed` / `getAllowPaths` delegate to it; new 
`getAllowListPathChecker()` accessor
   - `FileSystemConfigSetService` holds the checker instead of `CoreContainer`, 
removing the null-container hack and TODO from SOLR-18058
   - Deliberately not static: several nodes with different homes share a JVM in 
tests
   
   No behaviour change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to