janhoy commented on code in PR #900:
URL: https://github.com/apache/solr-operator/pull/900#discussion_r4619250949


##########
docs/modules/upgrade-notes/pages/upgrade-notes.adoc:
##########
@@ -136,6 +136,10 @@ _Note that the Helm chart version does not contain a `v` 
prefix, which the downl
 
 === v0.10.0
 
+* The Helm charts are now distributed as OCI artifacts, from 
`oci://ghcr.io/apache/solr-operator/helm/solr-operator` and 
`oci://ghcr.io/apache/solr-operator/helm/solr`.
+The Helm repository at `https://solr.apache.org/charts` still lists every 
release, so existing `helm repo add` setups and `helm dependency` references 
keep working, but its entries now point at the OCI registry, which requires 
Helm `v3.8` or later.

Review Comment:
   Neat trick. I did not know that helm's own registry now supported 
referencing OCI. So this is nice for those that want to stick to their own 
install scripts and not change their ways.



##########
docs/modules/getting-started/pages/running-the-operator.adoc:
##########
@@ -34,6 +34,10 @@ $ helm repo add apache-solr https://solr.apache.org/charts
 $ helm repo update

Review Comment:
   Like in chart README, I think we should promote the far more robust and 
simple install-from-OCI procedure, and mention in a TIP box that `helm repo *` 
still works.



##########
helm/solr-operator/README.md:
##########
@@ -38,6 +38,9 @@ You should only need to add the solr operator helm chart 
repository once, by run
 helm repo add apache-solr https://solr.apache.org/charts
 ```
 
+The charts are published as OCI artifacts to 
`oci://ghcr.io/apache/solr-operator/helm`, and the repository above lists them 
from there, which requires Helm 3.8 or later.
+Instead of adding the repository, you can also install straight from the OCI 
registry, by replacing `apache-solr/solr-operator` in the commands below with 
`oci://ghcr.io/apache/solr-operator/helm/solr-operator`.

Review Comment:
   I'd be very much in favor of promoting the OCI way first, and mention in a 
footnote that the classic helm repo route also will keep working. I hate that 
`helm repo *` mechanics, only positive with it is you can list the versions.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to