squallsama opened a new pull request, #5367:
URL: https://github.com/apache/solr/pull/5367

   https://issues.apache.org/jira/browse/SOLR-18676
   
   # Description
   
   Backport of #5366 to `branch_10x`: Combined Query (RRF) fuses on a single 
core in standalone and embedded Solr instead of distributing every request, and 
two bugs of the distributed path are fixed (single-pass requests returned a 
sub-query's score instead of the fused one; elevation matching only some 
sub-queries failed the request). See #5366 for the full description.
   
   # Solution
   
   `git cherry-pick -x` of the commit of #5366; it applies without conflicts. 
The production code is identical to #5366.
   
   Test differences, because weighted RRF (SOLR-18542) is not on this branch:
   
   * the weighted-RRF cases (`combiner.rrf.weight.*`, valid and invalid) are 
left out of `CombinedQueryEmbeddedTest` and `CombinedQuerySingleCoreTest`;
   * the explanation test checks the ranks of a document but not which query 
each rank is named for: on this branch `ReciprocalRankFusion.getExplanations` 
takes the ranks in map order and the names in `combiner.query` order, so a rank 
can be named for the wrong query (fixed on main by SOLR-18542, independent of 
this change).
   
   This change was written with the help of an AI coding assistant (Claude 
Code), with `AGENTS.md` in context; I reviewed the code and the test results.
   
   # Tests
   
   On `branch_10x`: all `CombinedQuery*` suites (including the new 
`CombinedQuerySingleCoreTest`, 19 cases comparing embedded, standalone and 
distributed answers, and `CombinedQueryEmbeddedTest`), 
`DistributedCombinedQueryComponentTest`, `combine.*`, `TestDistributedSearch`, 
`DistributedQueryComponentOptimizationTest`, `CursorPagingTest`, 
`DistribCursorPagingTest`, `QueryElevationComponentTest`, 
`DistributedQueryElevationComponentTest`; `gradlew :solr:core:check -x test`.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] SOLR-18676: Combined Quer... squallsama (via GitHub) via issues

Reply via email to