github-actions[bot] commented on PR #5368:
URL: https://github.com/apache/solr/pull/5368#issuecomment-7035610693

   **Automated PR readiness judgements** (LLM-generated; may be wrong; not 
updated on later pushes).
   
   - ✅ [Jira issue in 
title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already 
present
   - ⚠️ 
[Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference)
 **— missing** (suggest type: fixed): The change fixes a bug where 
`bin/​solr start` would fail with a timeout on TLS nodes because 
the readiness check polled `localhost` instead of the advertised 
host, and it adds a fallback for mTLS scenarios where the host cannot 
connect.​
   - ✅ [Reference Guide 
update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not 
needed <!-- The change modifies internal CLI behavior for the &#96;solr 
start&#96; command&#39;s readiness wait logic and does not introduce new 
user&#45;facing configuration parameters&#44; API endpoints&#44; or documented 
behaviors that require Reference Guide updates&#46;​ -->
   - ✅ [Upgrade 
notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages):
 not needed <!-- The change is a bug fix that improves the reliability of the 
&#96;solr start&#96; command for TLS setups and does not remove or rename any 
public APIs&#44; parameters&#44; or configuration elements&#46;​ -->
   - ✅ Tests: included <!-- The PR modifies non&#45;trivial production logic in 
&#96;StatusTool&#46;​java&#96; and &#96;SolrProcessManager&#46;​java&#96; to 
handle TLS and mTLS readiness checks&#44; which warrants new or updated tests 
to verify the new behavior&#46;​ -->
   
   <!-- Assessed commit 196f8e7bd912754731f42bf671c7c559ff041ddd -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to