janhoy commented on code in PR #5329:
URL: https://github.com/apache/solr/pull/5329#discussion_r4642550738


##########
solr/packaging/test/test_secure_example.bats:
##########
@@ -107,27 +107,88 @@ teardown() {
     assert_failure
   done
 
-  run env SOLR_INCLUDE="$SOLR_HOME/tls/solr.in.sh" solr zk ls / --zk-host 
"localhost:$ZK_PORT"
+  run env SOLR_INCLUDE="$SOLR_HOME/tls/solr.in.sh" solr zk ls / --zk-host 
"localhost:$ZK_PORT/solr"

Review Comment:
   🤖 This PR extends the secure-example test in `test_secure_example.bats` with 
checks for the TLS-only embedded ZooKeeper: the chroot, the ZK status page, 
`zoo.cfg` contents, plain clients timing out, and automatic TLS on a normal 
HTTPS start. BATS is going away: CATS (SOLR-18642, #5323) has replaced it on 
`main`, and SOLR-18645 (#5369) removes the `.bats` files. Please port these 
checks to `SecureExampleTest` in 
`solr/packaging/src/test/org/apache/solr/shell/`. It is a nightly test, so run 
it with `-Ptests.nightly=true`. See 
[dev-docs/cats.adoc](https://github.com/apache/solr/blob/main/dev-docs/cats.adoc)
 for porting help.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to