iprithv commented on code in PR #5337:
URL: https://github.com/apache/solr/pull/5337#discussion_r4647311621


##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -151,9 +152,8 @@ public static void main(String[] args) throws Exception {
   }
 
   /**
-   * The {@code bin/solr} script invokes the tool with a single empty argument 
when it wants the
-   * top-level help (see the {@code --help} handling in {@code bin/solr}). 
picocli would treat that
-   * empty string as an unknown subcommand, so drop it.
+   * Drops a leading empty argument. Kept for back-compat with older {@code 
bin/solr} scripts that

Review Comment:
   yeah, makes sense. dropped it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to