rahulgoswami commented on code in PR #5356:
URL: https://github.com/apache/solr/pull/5356#discussion_r4650605925
##########
solr/core/src/java/org/apache/solr/search/join/GraphQuery.java:
##########
@@ -193,6 +203,8 @@ private DocSet getDocSet() throws IOException {
Query frontierQuery = q;
// Find all documents in this graph that are leaf nodes to speed
traversal
DocSet leafNodes = resolveLeafNodes();
+ // Find all documents whose edges may be followed, if restricted by a
lookup filter
+ DocSet lookupNodes = lookupFilter == null ? null :
fromSearcher.getDocSet(lookupFilter);
Review Comment:
Relatively minor edge case. Existing leaf node check has the same cost.
Skipping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]