epugh commented on code in PR #4874:
URL: https://github.com/apache/solr/pull/4874#discussion_r4655795545


##########
changelog/unreleased/SOLR-18417-remove-pingrequesthandler.yml:
##########
@@ -0,0 +1,7 @@
+type: removed
+title: `PingRequestHandler` (the "/admin/ping" endpoint), `SolrPing`, 
`SolrPingResponse`, and `SolrClient.ping()` have been removed.  Users looking 
for a healthcheck API can use `/api/node/health` (v2) or 
`/solr/admin/info/health` (v1) instead.  SolrJ users looking to replace "ping" 
functionality can either use `QueryRequest` for true query submission, or 
`HealthCheckRequest` for making a node-level healthcheck request.
+authors:
+  - name: Jason Gerlowski

Review Comment:
   Add Eric Pugh



##########
solr/core/src/test/org/apache/solr/handler/admin/api/GetConfigSolrCloudTest.java:
##########
@@ -128,7 +128,8 @@ public void testGetRequestHandlersFromCollection() throws 
Exception {
     Map<String, Object> configSection = (Map<String, Object>) 
response.config.get(REQUEST_HANDLERS);
     assertNotNull(configSection);
     assertTrue(configSection.containsKey("/select"));
-    assertTrue(configSection.containsKey("/admin/ping"));
+    assertTrue(configSection.containsKey("/admin/luke"));
+    assertFalse(configSection.containsKey("/admin/ping"));

Review Comment:
   We do t need this assertFalse



##########
changelog/unreleased/SOLR-18417-remove-pingrequesthandler.yml:
##########
@@ -0,0 +1,7 @@
+type: removed
+title: `PingRequestHandler` (the "/admin/ping" endpoint), `SolrPing`, 
`SolrPingResponse`, and `SolrClient.ping()` have been removed.  Users looking 
for a healthcheck API can use `/api/node/health` (v2) or 
`/solr/admin/info/health` (v1) instead.  SolrJ users looking to replace "ping" 
functionality can either use `QueryRequest` for true query submission, or 
`HealthCheckRequest` for making a node-level healthcheck request.

Review Comment:
   Let's simplify a bit



##########
solr/core/src/test/org/apache/solr/handler/admin/api/GetConfigTest.java:
##########
@@ -105,7 +105,8 @@ public void testGetRequestHandlersFromCore() throws 
Exception {
     Map<String, Object> configSection = (Map<String, Object>) 
response.config.get(REQUEST_HANDLERS);
     assertNotNull(configSection);
     assertTrue(configSection.containsKey("/select"));
-    assertTrue(configSection.containsKey("/admin/ping"));
+    assertTrue(configSection.containsKey("/admin/luke"));
+    assertFalse(configSection.containsKey("/admin/ping"));

Review Comment:
   Dont need this asssert false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to