github-actions[bot] commented on PR #5378: URL: https://github.com/apache/solr/pull/5378#issuecomment-7073505520
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ⚠️ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) **— missing**: This fixes a user-visible bug where /admin/file returned a 500 ClassCastException in SolrCloud with a non-ZK ConfigSetService, which warrants a Jira issue and release note. - ⚠️ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) **— missing** (suggest type: fixed): The change fixes a ClassCastException (HTTP 500) in ShowFileRequestHandler for SolrCloud nodes using a file-system ConfigSetService, a user-visible symptom. - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not needed <!-- The change only alters internal dispatch logic in ShowFileRequestHandler to avoid a crash; it does not add or change any documented parameter, config, or API behavior that the Reference Guide should describe. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is a bug fix that makes /admin/file work in more cases; it is not a backwards-incompatible change requiring user action on upgrade. --> - ⚠️ Tests **— missing**: The PR changes non-trivial production logic in ShowFileRequestHandler.handleRequestBody (the condition selecting the ZK vs file-system path), and the author notes no automated test was added, so a test covering a non-ZK ConfigSet in SolrCloud is warranted. <!-- Assessed commit 839f7cbeeda95fd8d2bd67cf61029b202620ffda --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
