github-actions[bot] commented on PR #5378:
URL: https://github.com/apache/solr/pull/5378#issuecomment-7073505520

   **Automated PR readiness judgements** (LLM-generated; may be wrong; not 
updated on later pushes).
   
   - ⚠️ [Jira issue in 
title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) **— missing**: 
This fixes a user-visible bug where /​admin/​file returned a 500 
ClassCastException in SolrCloud with a non-ZK ConfigSetService, which 
warrants a Jira issue and release note.​
   - ⚠️ 
[Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference)
 **— missing** (suggest type: fixed): The change fixes a ClassCastException 
(HTTP 500) in ShowFileRequestHandler for SolrCloud nodes using a 
file-system ConfigSetService, a user-visible symptom.​
   - ✅ [Reference Guide 
update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): not 
needed <!-- The change only alters internal dispatch logic in 
ShowFileRequestHandler to avoid a crash&#59; it does not add or change any 
documented parameter&#44; config&#44; or API behavior that the Reference Guide 
should describe&#46;​ -->
   - ✅ [Upgrade 
notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages):
 not needed <!-- The change is a bug fix that makes &#47;​admin&#47;​file work 
in more cases&#59; it is not a backwards&#45;incompatible change requiring user 
action on upgrade&#46;​ -->
   - ⚠️ Tests **— missing**: The PR changes non&#45;trivial production logic in 
ShowFileRequestHandler&#46;​handleRequestBody &#40;the condition selecting the 
ZK vs file&#45;system path&#41;&#44; and the author notes no automated test was 
added&#44; so a test covering a non&#45;ZK ConfigSet in SolrCloud is 
warranted&#46;​
   
   <!-- Assessed commit 839f7cbeeda95fd8d2bd67cf61029b202620ffda -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to