[
https://issues.apache.org/jira/browse/SPARK-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973148#comment-13973148
]
Sean Owen commented on SPARK-1527:
----------------------------------
There are a number of other uses of File.getName(), but a quick glance suggests
all the others are appropriate.
There are a number of other uses of File.toString(), almost all in tests. I
suspect the Files in question already have absolute paths, and that even
relative paths happen to work fine in a test since the working dir doesn't
change. So those could change, but are probably not a concern.
The only one that gave me pause was the use in HttpBroadcast.scala, though I
suspect it turns out to work fine for similar reasons.
If reviewers are interested in changing the toString()s I'll test and submit a
PR for that.
> rootDirs in DiskBlockManagerSuite doesn't get full path from rootDir0,
> rootDir1
> -------------------------------------------------------------------------------
>
> Key: SPARK-1527
> URL: https://issues.apache.org/jira/browse/SPARK-1527
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
> Affects Versions: 0.9.0
> Reporter: Ye Xianjin
> Priority: Minor
> Labels: starter
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In core/src/test/scala/org/apache/storage/DiskBlockManagerSuite.scala
> val rootDir0 = Files.createTempDir()
> rootDir0.deleteOnExit()
> val rootDir1 = Files.createTempDir()
> rootDir1.deleteOnExit()
> val rootDirs = rootDir0.getName + "," + rootDir1.getName
> rootDir0 and rootDir1 are in system's temporary directory.
> rootDir0.getName will not get the full path of the directory but the last
> component of the directory. When passing to DiskBlockManage constructor, the
> DiskBlockerManger creates directories in pwd not the temporary directory.
> rootDir0.toString will fix this issue.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
