[ 
https://issues.apache.org/jira/browse/SPARK-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041375#comment-14041375
 ] 

Ankur Dave commented on SPARK-2245:
-----------------------------------

I think it should suffice to override the public methods (checkpoint, 
isCheckpointed, getCheckpointFile), because the private ones (checkpointData, 
computeOrReadCheckpoint, doCheckpoint, markCheckpointed) were only called by 
the implementations of the public methods.

It would be great if you could modify your pull request to override these 
public methods. I don't think a test is necessary, since we're just delegating 
to the RDD methods.

> VertexRDD can not be materialized for checkpointing
> ---------------------------------------------------
>
>                 Key: SPARK-2245
>                 URL: https://issues.apache.org/jira/browse/SPARK-2245
>             Project: Spark
>          Issue Type: Bug
>          Components: GraphX
>            Reporter: Baoxu Shi
>
> Seems one can not materialize VertexRDD by simply calling count method, which 
> is overridden by VertexRDD. But if you call RDD's count, it could materialize 
> it.
> Is this a feature that designed to get the count without materialize 
> VertexRDD? If so, do you guys think it is necessary to add a materialize 
> method to VertexRDD?
> By the way, does count() is the cheapest way to materialize a RDD? Or it just 
> cost the same resources like other actions?
> The pull request is here:
> https://github.com/apache/spark/pull/1177
> Best,



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to