[ https://issues.apache.org/jira/browse/SPARK-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096689#comment-14096689 ]
Patrick Wendell edited comment on SPARK-3028 at 8/14/14 7:20 AM: ----------------------------------------------------------------- I think we currently do not intend to ever serialize an update event as JSON. However, I think we should be more explicit about this in two ways. 1. In EventLoggingListener we should explicit put a no-op implementation of onExecutorMetricsUpdate with a comment - I actually thought one version of the PR had this, but maybe I'm misremembering. 2. We should also include the SparkListenerExecutorMetricsUpdate in the match block and just have a no-op there also with a comment. was (Author: pwendell): I think we explicitly do not intend to ever serialize an update event as JSON. However, I think we should be more explicit about this in two ways. 1. In EventLoggingListener we should explicit put a no-op implementation of onExecutorMetricsUpdate with a comment - I actually thought one version of the PR had this, but maybe I'm misremembering. 2. We should also include the SparkListenerExecutorMetricsUpdate in the match block and just have a no-op there also with a comment. > sparkEventToJson should support SparkListenerExecutorMetricsUpdate > ------------------------------------------------------------------ > > Key: SPARK-3028 > URL: https://issues.apache.org/jira/browse/SPARK-3028 > Project: Spark > Issue Type: Bug > Components: Spark Core > Reporter: Reynold Xin > Priority: Blocker > > SparkListenerExecutorMetricsUpdate was added without updating > org.apache.spark.util.JsonProtocol.sparkEventToJson. > This can crash the listener. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org