[ 
https://issues.apache.org/jira/browse/SPARK-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225251#comment-15225251
 ] 

Marcelo Vanzin commented on SPARK-14391:
----------------------------------------

I made an internal change to increase timeouts for those tests and things seem 
more stable here:

{noformat}
--- a/launcher/src/test/java/org/apache/spark/launcher/LauncherServerSuite.java
+++ b/launcher/src/test/java/org/apache/spark/launcher/LauncherServerSuite.java
@@ -91,7 +91,7 @@ public class LauncherServerSuite extends BaseSuite {
       client = new TestClient(s);
       synchronized (waitLock) {
         client.send(new Hello(handle.getSecret(), "1.4.0"));
-        waitLock.wait(TimeUnit.SECONDS.toMillis(10));
+        waitLock.wait(TimeUnit.SECONDS.toMillis(30));
       }
 
       // Make sure the server matched the client to the handle.
@@ -99,18 +99,18 @@ public class LauncherServerSuite extends BaseSuite {
 
       synchronized (waitLock) {
         client.send(new SetAppId("app-id"));
-        waitLock.wait(TimeUnit.SECONDS.toMillis(10));
+        waitLock.wait(TimeUnit.SECONDS.toMillis(30));
       }
       assertEquals("app-id", handle.getAppId());
 
       synchronized (waitLock) {
         client.send(new SetState(SparkAppHandle.State.RUNNING));
-        waitLock.wait(TimeUnit.SECONDS.toMillis(10));
+        waitLock.wait(TimeUnit.SECONDS.toMillis(30));
       }
       assertEquals(SparkAppHandle.State.RUNNING, handle.getState());
 
       handle.stop();
-      Message stopMsg = client.inbound.poll(10, TimeUnit.SECONDS);
+      Message stopMsg = client.inbound.poll(30, TimeUnit.SECONDS);
       assertTrue(stopMsg instanceof Stop);
     } finally {
       kill(handle);
{noformat}

Never underestimate how long things can take to run on shared machines...

> Flaky Test org.apache.spark.launcher.LauncherServerSuite.testCommunication
> --------------------------------------------------------------------------
>
>                 Key: SPARK-14391
>                 URL: https://issues.apache.org/jira/browse/SPARK-14391
>             Project: Spark
>          Issue Type: Test
>          Components: Spark Submit
>            Reporter: Burak Yavuz
>              Labels: flaky-test
>
> Several Failures:
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54893
> https://spark-tests.appspot.com/tests/org.apache.spark.launcher.LauncherServerSuite/testCommunication



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to