Liang-Chi Hsieh created SPARK-14627:
---------------------------------------

             Summary: In TypedAggregateExpression update method we call 
encoder.shift many times
                 Key: SPARK-14627
                 URL: https://issues.apache.org/jira/browse/SPARK-14627
             Project: Spark
          Issue Type: Improvement
            Reporter: Liang-Chi Hsieh
            Priority: Minor


Every time we call TypedAggregateExpression.update method, we call encoder's 
shift method. As shift method will copy encoder and underlying BoundReference, 
we should prepare the shifted encoder in advance, instead of calling shift 
method every time.

BTW, we can also improve encoder's shift method to return itself when shift 
delta is zero.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to