[ https://issues.apache.org/jira/browse/SPARK-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247576#comment-15247576 ]
Takeshi Yamamuro commented on SPARK-14525: ------------------------------------------ Yeah, +1. I'm not sure we have a special handling for the `jdbc` source. I think it would be better to move all the jdbc functionality of `DataFrameWriter` into `jdbc.DefaultSource`, then duplicate `read.format("jdbc"). > DataFrameWriter's save method should delegate to jdbc for jdbc datasource > ------------------------------------------------------------------------- > > Key: SPARK-14525 > URL: https://issues.apache.org/jira/browse/SPARK-14525 > Project: Spark > Issue Type: Improvement > Components: SQL > Affects Versions: 1.6.1 > Reporter: Justin Pihony > Priority: Minor > > If you call {code}df.write.format("jdbc")...save(){code} then you get an > error > bq. org.apache.spark.sql.execution.datasources.jdbc.DefaultSource does not > allow create table as select > save is a more intuitive guess on the appropriate method to call, so the user > should not be punished for not knowing about the jdbc method. > Obviously, this will require the caller to have set up the correct parameters > for jdbc to work :) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org