[
https://issues.apache.org/jira/browse/SPARK-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261246#comment-15261246
]
Yin Huai commented on SPARK-14591:
----------------------------------
Thanks! So, keywords in the list of
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4#L680-L905
that do not show up in the nonReserved list are all reserved?
> Remove org.apache.spark.sql.catalyst.parser.DataTypeParser
> ----------------------------------------------------------
>
> Key: SPARK-14591
> URL: https://issues.apache.org/jira/browse/SPARK-14591
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Reporter: Yin Huai
>
> Since our parser defined based on antlr 4 can parse data type (see
> CatalystSqlParser), we can remove
> org.apache.spark.sql.catalyst.parser.DataTypeParser. Let's make sure the new
> parser's functionality is a super set of DataTypeParser. Then, we can remove
> DataTypeParser. For the object DataTypeParser, we can keep it and let it just
> call the parserDataType method of CatalystSqlParser.
> *The original description is shown below*
> Right now, our DDLParser does not support {{decimal(precision)}} (the scale
> will be set to 0). We should support it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
