[
https://issues.apache.org/jira/browse/SPARK-15451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293958#comment-15293958
]
Marcelo Vanzin edited comment on SPARK-15451 at 5/20/16 6:49 PM:
-----------------------------------------------------------------
I'm not suggestion building twice. I'm suggesting building whatever needs to be
compatible with jdk7 using jdk7 (or at least using jdk7's rt.jar).
was (Author: vanzin):
I'm not suggestion building twice. I'm suggesting build whatever needs to be
compatible with jdk7 using jdk7 (or at least using jdk7's rt.jar).
> Spark PR builder should fail if code doesn't compile against JDK 7
> ------------------------------------------------------------------
>
> Key: SPARK-15451
> URL: https://issues.apache.org/jira/browse/SPARK-15451
> Project: Spark
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.0.0
> Reporter: Marcelo Vanzin
>
> We need to compile certain parts of the build using jdk8, so that we test
> things like lambdas. But when possible, we should either compile using jdk7,
> or provide jdk7's rt.jar to javac. Otherwise it's way too easy to slip in
> jdk8-specific library calls.
> I'll take a look at fixing the maven / sbt files, but I'm not sure how to
> update the PR builders since this will most probably require at least a new
> env variable (to say where jdk7 is).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
