[ https://issues.apache.org/jira/browse/SPARK-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reynold Xin updated SPARK-16489: -------------------------------- Description: In code generation, it is incorrect for expressions to reuse variable names across different instances of itself. As an example, SPARK-16488 reports a bug in which pmod expression reuses variable name "r". This patch updates ExpressionEvalHelper test harness to always project two instances of the same expression, which will help us catch variable reuse problems in expression unit tests. > Test harness to prevent expression code generation from reusing variable names > ------------------------------------------------------------------------------ > > Key: SPARK-16489 > URL: https://issues.apache.org/jira/browse/SPARK-16489 > Project: Spark > Issue Type: Bug > Components: SQL > Reporter: Reynold Xin > Assignee: Reynold Xin > > In code generation, it is incorrect for expressions to reuse variable names > across different instances of itself. As an example, SPARK-16488 reports a > bug in which pmod expression reuses variable name "r". > This patch updates ExpressionEvalHelper test harness to always project two > instances of the same expression, which will help us catch variable reuse > problems in expression unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org