[ 
https://issues.apache.org/jira/browse/SPARK-16779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397984#comment-15397984
 ] 

holdenk edited comment on SPARK-16779 at 7/28/16 6:36 PM:
----------------------------------------------------------

I'm sort of on the fence with fixing as well - but we are also using it for 
command execution with {quote}!!{quote} which (in my opinion) doesn't increase 
readability at all. So my current plan is to make a small fix to the one place 
where we don't have the warning squelched with doing {quote}!!{quote} and if 
people agree that its cleaner without it - I'll go through and cleanup the rest 
of the {quote}!!{quote} places.


was (Author: holdenk):
I'm sort of on the fence with fixing as well - but we are also using it for 
command execution with "!!" which (in my opinion) doesn't increase readability 
at all. So my current plan is to make a small fix to the one place where we 
don't have the warning squelched with doing "!!" and if people agree that its 
cleaner without it - I'll go through and cleanup the rest of the "!!" places.

> Fix unnecessary use of postfix operations
> -----------------------------------------
>
>                 Key: SPARK-16779
>                 URL: https://issues.apache.org/jira/browse/SPARK-16779
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: holdenk
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to