[ 
https://issues.apache.org/jira/browse/SPARK-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412459#comment-15412459
 ] 

Vladimir Feinberg commented on SPARK-12381:
-------------------------------------------

Yeah, that'd be a good idea.

> Copy public decision tree helper classes from spark.mllib to spark.ml and 
> make private
> --------------------------------------------------------------------------------------
>
>                 Key: SPARK-12381
>                 URL: https://issues.apache.org/jira/browse/SPARK-12381
>             Project: Spark
>          Issue Type: Sub-task
>          Components: ML, MLlib
>            Reporter: Seth Hendrickson
>
> The helper classes for decision trees and decision tree ensembles (e.g. 
> Impurity, InformationGainStats, ImpurityStats, DTStatsAggregator, etc...) 
> currently reside in spark.mllib, but as the algorithm implementations are 
> moved to spark.ml, so should these helper classes.
> We should take this opportunity to make some of those helper classes private 
> when possible (especially if they are only needed during training) and maybe 
> change the APIs (especially if we can eliminate duplicate data stored in the 
> final model).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to